The Big Overhaul #292
Open
The Big Overhaul #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of IllegalStateException with "Invalid BootstrapMethods attribute entry: 2 additional arguments required for method java/lang/invoke/StringConcatFactory.makeConcatWithConstants, but only 1 specified." this is a known issue of Procyon <= 0.5.35 and the available fix it not yet released, refer to https://bitbucket.org/mstrobel/procyon/issues/336/ The search does not stop anymore, simply a hint is given in found class list for that error. In case of other IllegalStateException or general Exceptions hold on the search in remaining files, too. For example, my openJDK 11 based WAR file has other error cases in Procyon too. java.lang.IllegalArgumentException: Argument 'value' must be in the range [1, 18], but value was: 19. java.lang.IllegalArgumentException: Argument 'value' must be in the range [1, 18], but value was: 20. both at com.strobel.core.VerifyArgument.inRange(VerifyArgument.java:347)
Up until now, if you open two jar files that contain the class e.g. `test.package.TestClass` and you open this class of the first jar, the one from the second jar will look exactly like the first one.
This doesn't fix Java 17, though
Closed
|
Soooo, I created a new branch where you can see a "better" comparison of my work and your current Apart from that, here is the (more or less) complete changelog:
|
|
Thanks, it's useful. |
|
@deathmarine Procyon 0.6 stable has arrived with huge changes! |
|
@deathmarine Any updates on this? :) |
|
the hyperlinks (i.e, CTRL+click on classes, methods, fields,...) have stopped working, can you check that ? |
|
@nbauma109 You are right, I debugged the problem and it is an issue with RSTA >=3.1.0. See this issue for followups: bobbylight/RSyntaxTextArea#443 |
|
@nbauma109 Applied a workaround for the time being. See new release 0.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Big Overhaul
The old PR was removed since I renamed my branch, Here is the replacement.
Download
Download available here
Changes
Changes can best be seen here: master...ThexXTURBOXx:better-diff
Summary
PATHandJAVA_HOMEenvironment variablesfinalkeywords, remove unnecessary instructions, improve boolean expressions etc.)src/main/[java\resources]layout by default; this allows for a cleanerpom.xml)META-INF/MANIFEST.MFdirectlyconsoleto allow CLI on theexefile (and most likely the other ones as well); caveat: When opening via double-click, a console appearsIssues fixed (probably more, but here are a few selected ones :) )
Fixes #100
Closes #138
Closes #150
Closes #165
Closes #200
Closes #254
Fixes #294
Fixes #296
Fixes #297
Fixes #302
Fixes #304
Fixes #305
Fixes #306
Fixes #307
Fixes #314
Fixes #315
Fixes #316
Fixes #317
Fixes #318