Fix rubocop failures and github checkout version #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have development dependencies listed in the gemspec, we have to include a rubocop configuration stanza. Remove gem sidekiq from top-level Gemfile as a result of it being in the gemspec. Let appraisal gem remake all the dependent gemfiles for CI.
matt-domsch-sp
force-pushed
the
rubocop-github-checkout
branch
from
3bea7a7
to
a0a30dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop wants the development dependencies to be specified in the Gemfile. Ours are in gemspec. Override the rubocop rule. Ignore the demo/ directory that just specifies gem sidekiq in Gemfile. Re-establish the lockfiles for CI as a result.
GitHub has a new version of the checkout action needed for newer nodejs.