New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breaking change in bulk_requeue #111
Conversation
@vinc Would you mind adding a test? |
That's a good idea yeah. The method isn't called anywhere directly in this gem so maybe the best would be to simply copy/adapt sidekiq's test: https://github.com/mperham/sidekiq/blob/master/test/test_fetch.rb#L39 Another thing to do I realized is to either set the minimum required version of sidekiq to 6.1.0 or to check if |
Hey guys! Any chance this PR to be merged? This project has no new updates since 2017 :-/ |
Hey @m3nd3s, in issue #106 @brainopia expressed willingness to transfer ownership of the gem to a new maintainer but nobody answered to take up the challenge. And I can understand that, this gems seems a bit tricky to maintain when you look at the open issues. For now I forked the gem to https://github.com/Augment/sidekiq-limit_fetch as we already have a few other gems in the same situation, but we don't currently have the required time to take proper ownership of the gem and assume a maintainer role unfortunately. |
OK @vinc Probably we'll fork the repository with the fix 😄 , thank you so much. |
Thanks @vinc ! |
Is there a workaround for this, in the meantime? |
hey @macmartine you can fork and use the fork/repository fixed by @vinc . See #111 (comment) But, I think it is better remove or replace the SidekiqLimitFetch from your repository in the future. |
Please merge this |
It looks like the bulk_requeue issue has been fixed in master with #115 |
I'm closing this PR as it's fixed in the other merged one 👍 |
In Sidekiq version 6.1.0 the internal method
bulk_requeue
became an instance method instead of a class method, this PR should fix this by creating aSidekiq::BasicFetch
instance withSidekiq::options
.See #110 and sidekiq/sidekiq#4602