Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix devcontainers postCreateCommand permissions, fixes #6187 #6194

Merged
merged 1 commit into from
May 16, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented May 16, 2024

The Issue

How This PR Solves The Issue

Sets directory permissions for /workspaces/d10simple
Removes hard-coded path for /workspaces/ddev (because users can clone the repo to a different directory).

Manual Testing Instructions

git clone https://github.com/ddev/ddev.git my-ddev-copy
code my-ddev-copy

# install Dev Containers extension
# Menu > View > Command Palette... > Dev Containers: Reopen in Container
# wait some time, I had to wait ~10 minutes

ls -l /workspaces
total 8
drwxr-xr-x  7 codespace codespace 4096 May 16 12:40 d10simple
drwxr-xr-x 25 codespace codespace 4096 May 16 11:46 my-ddev-copy

Open in GitHub Codespaces

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine for me in codespaces, thanks!

@rfay rfay merged commit 6fdd16d into ddev:master May 16, 2024
19 of 21 checks passed
@stasadev stasadev deleted the 20240516_stasadev_devcontainers branch May 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants