fix: Drupal - switch to sendmail transport always in settings.ddev.php #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… switch to Mailpit
rfay
changed the title
|
Thanks @doradovictor - Could you please update the OP to show what your situation was and why you ran into this? Thanks! |
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
changed the title
I tried to explain it better! 😊 |
|
Sorry for the conflict here @doradovictor but there was a phpcs-based refactor that went in before yours, Would you mind rebasing this (or just recreating it if that's easier)? |
…_transports_support
|
@rfay I followed Github instructions and merged master with my branch, resolving conflicts. Is it ok now? :) |
penyaskito
approved these changes
May 22, 2024
penyaskito
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
When you have other default transport than sendmail, DDEV doesn't switch correctly Drupal config to use Mailpit.
We ran into this issue because we were using a custom transport in order to send our mails through an external service (Sendgrid). If "sendmail" is not the default transport, current DDEV tweaking technique for redirecting mail to Mailpit is not taking effect.
How This PR Solves The Issue
It also sets the default transport as sendmail, besides changing the sendmail transport configuration.
Manual Testing Instructions
Configure another transport in Drupal Symfony Mailer and test that it is correctly overriden by DDEV to use Mailpit.