Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codespaces needs https port as base #6101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 15, 2024

The Issue

The URL provided for codespaces doesn't seem to work right, see https://discord.com/channels/664580571770388500/1229209241714163802/1229209241714163802

How This PR Solves The Issue

Use the https port for codespaces

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link

github-actions bot commented Apr 16, 2024

@stasadev
Copy link
Member

stasadev commented May 13, 2024

I should note:

If we decide to change the port here, we will also need to change $DDEV_HOST_WEBSERVER_PORT to $DDEV_HOST_HTTPS_PORT in ddev launch (and change the Gitpod port, because it uses the same FULLURL):

-m|--mailpit|--mailhog)
if [[ ! -z "${GITPOD_INSTANCE_ID}" ]] || [[ "${CODESPACES}" == "true" ]]; then
FULLURL="${FULLURL/-${DDEV_HOST_WEBSERVER_PORT}/-${DDEV_HOST_MAILPIT_PORT}}"
else

@rfay rfay force-pushed the 20240415_codespaces_url branch from 93b0218 to 8a957af Compare May 22, 2024 01:29
@rfay
Copy link
Member Author

rfay commented May 22, 2024

AFAICT, this is the only way known to fix the problem with drupal10, and it does work.

@stasadev
Copy link
Member

stasadev commented May 22, 2024

If it works with drupal10, that's good. But it needs more changes, as I mentioned in my previous comment, because changing the port breaks ddev launch -m, ddev mailpit:

DDEV_DEBUG=true ddev mailpit
FULLURL https://solid-guide-jr4pvqvxxgqf56rj-8443.app.github.dev

The port in the URL is not replaced from 8443 to 8027.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants