build: bump docker-compose to v2.25.0

[rfay]

The Issue

docker-compose v2.25.0 was released. Run tests on it.

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

Wow, completely 100% failed!

[rfay]

It seems that the router is broken and is sending the request elsewhere? Maybe some labels are messed up or something.

• Using the 127.0.0.1 URL provided by ddev start works fine
• docker exec -it ddev-router bash and curl http://ddev-d10-web works fine
• Watching logs from docker logs -f ddev-router when doing curl https://d10.ddev.site gets a 404 and

172.24.0.1 - - [07/Mar/2024:00:47:21 +0000] "GET / HTTP/2.0" 404 19 "-" "-" 139 "-" "-" 0ms

I think the router is probably trying to hit itself?

With v1.22.7 I get
172.29.0.1 - - [07/Mar/2024:01:04:12 +0000] "GET / HTTP/2.0" 200 36377 "-" "-" 4 "d10-web-80-https@file" "http://ddev-d10-web:80" 297ms

[rfay]

It works fine with docker-compose v2.24.6. ddev config global --required-docker-compose-version=v2.24.6

But nothing at all works with 2.24.7.

Unless it's the networks change in https://github.com/docker/compose/releases/tag/v2.24.7 I don't know what it would be. git bisect may be the path to study it (of compose). Or just wait for issues to show up in their queue?

[stasadev]

I tested commits for v2.24.7 docker-compose release.

The bug is somewhere in:

• restore support for config --no-interpolate docker/compose#11556

[rfay]

Thanks for the research!

I think it's actually breaking something about ddev-router/traefik usage.

[stasadev]

Or just wait for issues to show up in their queue?

Yes, found a bug report for this exact problem 😅:

• [BUG] v2.24.7 multiple changes in config output docker/compose#11589

[stasadev]

I think it's actually breaking something about ddev-router/traefik usage.

Compared the contents of ~/.ddev/.router-compose-full.yaml:

v2.24.5:

networks:
  ddev_default:
    external: true
    name: ddev_default

v2.24.7

networks:
  ddev_default:
    external: true
    name: ddev_default
  default:
    name: ddev-d10_default

and when you start another project:

networks:
  ddev_default:
    external: true
    name: ddev_default
  default:
    name: ddev-project_default

[rfay]

Thanks for the great chasing @stasadev

Closing this one for now, we'll watch

• [BUG] v2.24.7 multiple changes in config output docker/compose#11589

[stasadev]

Reopening with rebase and trying to fix our code for docker-compose v2.24.7

[stasadev]

There is still a bug with the default network, which is created when we are not asked to do so, but this should not prevent the code from running:

[stasadev]

It still doesn't work because I made changes in only one place, the fix for the output should be made in:

ddev/pkg/ddevapp/compose_yaml.go

Line 76 in a4bf20b

func fixupComposeYaml(yamlStr string, app *DdevApp) (map[string]interface{}, error) {

[rfay]

I guess we should go ahead and go with this? Or should we try to adopt their new format at this time?

[stasadev]

I think we should update docker-compose to v2.25.0.