Allow overriding config in config.*.yaml using override_config: true, fixes #4100, fixes #4079, fixes #4099
#4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
This was referenced Aug 13, 2022
rfay
force-pushed
the
20220813_config_yaml_override
branch
2 times, most recently
from
ae37122
to
a313b1e
Compare
rfay
force-pushed
the
20220813_config_yaml_override
branch
from
a313b1e
to
f5cae68
Compare
|
Tested with |
|
A related advance in docker-compose, compose-spec/compose-spec#340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
DDEV v1.20.0 introduced the merging approach to
config.*.yamlthat most people seemed to expect over the years, but it turned out there were many people who had used the old (overwrite everything) behavior to good effect and needed the old behavior.How this PR Solves The Problem:
Add
override_config: trueoption that can be added to anyconfig.*.yamlfile to signal that its contents should override instead of merging.Manual Testing Instructions:
Add
override_config: trueto anyconfig.*.yamland the behavior for that file only is changed to override instead of merge.Try out the things people complained about:
nfs_mount_enabled: falseadditional_hostnames: []Automated Testing Overview: