[WIP] Add tests

[YurySolovyov]

I thought it would be nice to start a PR right away, so we can discuss everything as we go.

Some notes:

• fixed old image thumb, we should really find more reliable image with persistent url
• split up interface creators
• I started with jasmine as I thought it has pretty lightweight setup and everything I need ATM.

Feel free to leave a comment or commit some stuff as I will squash everything at the end.

Fixes #7

[emersion]

You can just write jasmine, NPM will expand it to node_modules/.bin/jasmine automatically.

[emersion]

Looks very good! We can also get rid of all the ugly _create*Interface methods by using Symbol() and use ES6 since this thing will only be used in Node.

Also, in the tests what happens if done is never called? Is there a timeout?

[YurySolovyov]

Some questions:

• do you have any particular minimal node version for this? I mean if you are ok with targeting node 4 LTS, we could use some ES6 here like const/let, classes, Promises and so on.
• I wonder if we can set up a CI to run the tests, though I'm not sure if we will be able to provide all dbus deps for it.

[YurySolovyov]

Is there a timeout?

Yes

[emersion]

do you have any particular minimal node version for this? I mean if you are ok with targeting node 4 LTS, we could use some ES6 here like const/let, classes, Promises and so on.

I think just targeting LTS will be fine. This module was written a long time ago, and needs ES6.

I wonder if we can set up a CI to run the tests, though I'm not sure if we will be able to provide all dbus deps for it.

I think this can work. Will try to do it.

[YurySolovyov]

I guess this needs everything from https://github.com/Shouqun/node-dbus#dependencies plus libexpat1-dev

[YurySolovyov]

Comment got hidden:

I guess this needs everything from https://github.com/Shouqun/node-dbus#dependencies plus libexpat1-dev

[emersion]

Note: if we want to rollback to precise on travis, we need:

• Install expat from source (v2.0 is missing a pkgconfig file, need v2.1): see https://wayland.freedesktop.org/ubuntu12.04.html
• Use a newer gcc and g++:

env:
  - CC=gcc-5 CXX=g++-5
addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - gcc-5
      - g++-5

[emersion]

Yay! The build now works :D

[emersion]

We should use .once() here to do not end up with a large number of listeners.

[YurySolovyov]

We can also get rid of all the ugly _create*Interface methods by using Symbol()

TBH, I don't like using Symbol. How about just making them classes and using them like so:

this.interfaces = {
  root: new RootInterface()
};
if (this.supportedInterfaces.includes('player')) {
    this.interfaces.player = new PlayerInterface();
}
if (this.supportedInterfaces.include('trackList')) {
    this.interfaces.trackList = new TrackListInterface();
}
if (this.supportedInterfaces.include('playlists')) {
    this.interfaces.playlists = new PlaylistsInterface();
}

[emersion]

Is it possible to get the interface outside the reduce?

[YurySolovyov]

good catch, will take a look

[YurySolovyov]

@emersion any news here?

[emersion]

Rebased all commits (but I should have just merged, too late :( ) with the latest fix in master. I get this:

Started
...*process 13125: arguments to dbus_message_iter_append_basic() were incorrect, assertion "_dbus_check_is_valid_path (*string_p)" failed in file dbus-message.c line 2758.
This is normally a bug in some application using the D-Bus library.
  D-Bus not built with -rdynamic so unable to print a backtrace
fish: “npm run test” terminated by signal SIGABRT (Abort)

[YurySolovyov]

You might want to show up in gitter :)

[emersion]

Superseded by #15