SecretContext for secret env vars, profiles + packages only #4311
+164
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gshank Couldn't have done it without you. The code reorg + annotations re: contexts are what made this possible |
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* SecretContext for secret env vars * Cleanup exception. Add + edit tests * Add changelog entry automatic commit by git-black, original commits: d300add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4310
Description
SecretContextfor use by theProfileRenderer(profiles.yml) +PackageRenderer(packages.yml)env_varcontext member will raise an exception (disallow_secret_env_var) if it encounters a var prefixed withDBT_ENV_SECRET_Adjust integration tests accordingly:
ParsingExceptionif secret env var is used in a modelprofiles.yml+packages.ymlenv_var())Checklist
CHANGELOG.mdand added information about my change