Skip to content

Alow snapshot defer #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2021
Merged

Alow snapshot defer #4296

merged 2 commits into from
Nov 17, 2021
+32 −11

Conversation

kadero
Copy link
Contributor

@kadero kadero commented Nov 17, 2021 •
edited
Loading

resolves #4110

Description

Allow --defer to dbt snapshot. Following implementation plan described here 🙂 .

Tested in dev:
image

⚠️ Not in scope of this PR and can be done later in another PR:

  • Add the --defer flag to the compile and docs subparsers, too
  • Move defer_to_manifest up from RunTask into CompileTask (its parent)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

Sorry, something went wrong.

@kadero kadero marked this pull request as ready for review November 17, 2021 09:50
@cla-bot cla-bot bot added the cla:yes label Nov 17, 2021
jtcohen6
jtcohen6 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadero Looks good! Nice work knocking these out :)

@jtcohen6
Copy link
Contributor

Closing and reopening to trigger adapter integration tests, just to be sure

@jtcohen6 jtcohen6 closed this Nov 17, 2021
@jtcohen6 jtcohen6 reopened this Nov 17, 2021
@jtcohen6 jtcohen6 merged commit 9d73304 into dbt-labs:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6

Assignees
No one assigned
Labels
cla:yes ok_to_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] dbt snapshot --defer
2 participants
@kadero @jtcohen6