Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint 8 compatibility #873

Merged
merged 35 commits into from
Jan 30, 2023
Merged

refactor: eslint 8 compatibility #873

merged 35 commits into from
Jan 30, 2023

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Jan 18, 2023 •
edited

@mfranzke
refactor: dependency has been moved to a new namespace
a503fb6 
from @stencil/eslint-plugin to @stencil-community/eslint-plugin
@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Jan 18, 2023
@mfranzke mfranzke added this to the Release 1.0 milestone Jan 18, 2023
@mfranzke mfranzke self-assigned this Jan 18, 2023
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/refactor-replaced-dependency-name

@mfranzke mfranzke marked this pull request as draft January 18, 2023 09:49
@mfranzke mfranzke marked this pull request as ready for review January 18, 2023 10:54
@mfranzke mfranzke enabled auto-merge (squash) January 18, 2023 11:03
@github-actions github-actions bot removed the cicd Changes inside .github folder label Jan 18, 2023
@mfranzke mfranzke mentioned this pull request Jan 24, 2023
Closed
@github-actions github-actions bot added cicd Changes inside .github folder vue-showcase labels Jan 25, 2023
@mfranzke mfranzke changed the title refactor: dependency has been moved to a new namespace refactor: eslint 8 compatibility Jan 25, 2023
@mfranzke mfranzke marked this pull request as ready for review January 30, 2023 07:31
@mfranzke mfranzke enabled auto-merge (squash) January 30, 2023 07:36
@mfranzke
refactor: we want the Nullish coalescing operator instead
49c3fc6 
as this is what has been previously implementation as a condition
@mfranzke mfranzke merged commit 6a2d949 into main Jan 30, 2023
@mfranzke mfranzke deleted the refactor-replaced-dependency-name branch January 30, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
angular-showcase cicd Changes inside .github folder dependencies Pull requests that update a dependency file playground-showcase react-showcase repo stencil vue-showcase
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfranzke @nmerget