feat(dropdown & overflow-menu): possibility to overwrite the icons #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/666-feat-provide-possibility-to-overwrite-the-standard-icons |
mfranzke
changed the title
mfranzke
changed the title
mfranzke
changed the title
annsch
reviewed
Dec 15, 2023
| } | ||
| // Possibility to define an individual icon | ||
| &[data-icon] { | ||
| @include icon("", 20, "outline", $partial: $partial); |
There was a problem hiding this comment.
ist it also possible to include a solid icon then?
nmerget
reviewed
Jan 2, 2024
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
This should open with "oppositeDirection" or have a "flex-end" to work like the default dropdown
github-actions
bot
added
the
documentation
auto-merge was automatically disabled
January 29, 2024 11:39
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #666