doc: colors documentation for dbux3 #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
annsch
commented
Oct 25, 2022
•
annsch
commented
- Examples
- Usage styles
- Intro text finalize
annsch
changed the title
annsch
changed the title
mfranzke
reviewed
Oct 25, 2022
refactor: let's use a dl dt/dd here for semantics
mfranzke
reviewed
Nov 9, 2022
Comment on lines
+13
to
+18
| <dt><b>Primary</b></dt><dd>base key color</dd> | ||
| <dt><b>On Primary</b></dt><dd>is applied to content (icons, text, etc.) that sits on top of primary</dd> | ||
| <dt><b>Primary Background-Light</b></dt><dd>background color for current key color. Only used for backrounds.</dd> | ||
| <dt><b>Primary Background Transparent</b></dt><dd>Transparent or semi transparent backgrounds for current key color, e.g. used for form field backgrounds.</dd> | ||
| <dt><b>On Primary Background</b></dt><dd>is applied to content (icons, text, etc.) that sits on top of primary background colors (background light or transparent).</dd> | ||
| <dt><b>On Primary Background Weak</b></dt><dd>is applied to content (icons, text, etc.) that sits on top of primary background colors (background light or transparent) and is a variant to weaken content on primary backgrounds.</dd> |
There was a problem hiding this comment.
@annsch you could style the dt elements in bold via CSS instead of the b HTML tags.
mfranzke
reviewed
Nov 9, 2022
Comment on lines
+5
to
+8
| ## Accessibility | ||
|
|
||
| SVGs are often conveyed inconsistently to assistive technologies. The component’s accessibility is also highly contextual. | ||
| For optimal user experience, use the aria-description prop to let assistive technology users know the purpose of the loading spinner. |
There was a problem hiding this comment.
@annsch I currently cannot connect the dots of this information from SVGs to colors.
mfranzke
reviewed
Nov 9, 2022
Comment on lines
+255
to
+283
|
|
||
| /** | ||
| * Colors Documentation | ||
| **/ | ||
|
|
||
| main.colors-documentation h2 { | ||
| margin-top: 3rem; | ||
| } | ||
|
|
||
| main.colors-documentation h3 { | ||
| margin-top: 2rem; | ||
| } | ||
|
|
||
| main.colors-documentation figure { | ||
| margin: 0; | ||
| display: grid; | ||
| grid-auto-columns: 50% 50%; | ||
| grid: 1fr 1fr; | ||
| grid-gap: 1rem; | ||
| grid-auto-flow: column; | ||
| } | ||
|
|
||
| main.colors-documentation img { | ||
| height: auto; | ||
| max-width: 100%; | ||
| border-radius: 0.875rem; | ||
| box-shadow: rgb(60 64 67 / 30%) 0px 1px 2px 0px, | ||
| rgb(60 64 67 / 15%) 0px 1px 3px 1px; | ||
| } |
There was a problem hiding this comment.
this file is provided by pattern lab system itself, so I've introduced a pattern-scaffolding-project-specific.scss file within DB UI Core. Let's adapt this to DB UI Base and probably even move this file from Core to Base and add these declarations afterwards.
mfranzke
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.