Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and pin dev-deps on aiobotocore 2.1.0 #9

Closed
wants to merge 3 commits into from

Conversation

dazza-codes
Copy link
Owner

@dazza-codes dazza-codes commented Dec 23, 2021

Could be issues with s3fs for updating to aiobotocore 2.1.0, see

There are failures in pandas and zarr:

FAILED tests/test_aio_s3fs.py::test_pandas_s3_io - AttributeError: module 'aiobotocore' has no attribute 'AioSession'
FAILED tests/test_aio_s3fs.py::test_zarr_s3_io - AttributeError: module 'aiobotocore' has no attribute 'AioSession'
ERROR tests/test_aio_s3fs.py::test_pandas_s3_io - AssertionError: assert 0 > 0
ERROR tests/test_aio_s3fs.py::test_zarr_s3_io - AssertionError: assert 0 > 0

There might be no point in further work on this until s3fs/pandas/zarr resolve things. I'm not sure what's going on with aiobotocore sem-ver releases, because an upgrade from 2.0.1 to 2.1.0 should not break an import like this. The change might require all consuming libs to use more explicit import paths like aiobotocore.session.AioSession (?).

@dazza-codes
Copy link
Owner Author

Abandoning this PR, because aiobotocore 2.1.2 is working OK.

@dazza-codes dazza-codes deleted the aiobotocore-2.1.0 branch October 29, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant