Attempt to ensure that we download the latest artifact #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, unfortunately, it looks like there's one test failure :-/ |
…hat are a couple days old
|
Testing this for a little while, it seems to occasionally still pull an artifact that's a couple days old, even though there may be like ~40 newer ones. Adding a new 'ensure_latest' configuration has seemed to fix it in early testing - let's see how this goes! |
dsnopek
changed the title
|
There is still some regression here. Look at the failed job. Any ideas? |
|
This turned out to be user error on our part, I have no comment on the issue at hand. |
|
@dsnopek are you still working on that? |
|
Can this be picked up again? |
|
+1 on wanting this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #240 for me!
When switching from 'listWorkflowRuns' to the 'listWorkflowRunsForRepo' end-point, it's returning the workflow runs in reverse chronological order (ie. newest to oldest), which means that newer artifacts are favored over older ones.