Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regexp filter for artifact name #237

Merged
merged 14 commits into from Apr 14, 2023
Merged

Add regexp filter for artifact name #237

merged 14 commits into from Apr 14, 2023

Conversation

EnricoMi
Copy link
Contributor

Currently, either one artifact (by name) or all artifacts can be downloaded.

This adds option filter, which is used as a regular expression to match the artifact names. Only those artifacts where the name matches the regular expression are downloaded.

@dawidd6
Copy link
Owner

dawidd6 commented Apr 13, 2023

  • name and filter inputs conflict with each other, what happens is someone specifies both?
  • you need to add the input to action.yml too
  • some CI job to test this new input would be nice
  • I would lean towards a slightly different way, make filter input be a boolean and treat name input as regex if filter: true (defaulting to false for backward compat)

action.yml Outdated Show resolved Hide resolved
@dawidd6 dawidd6 merged commit 246dbf4 into dawidd6:master Apr 14, 2023
16 checks passed
@dawidd6
Copy link
Owner

dawidd6 commented Apr 14, 2023

Nice work, thanks!

@EnricoMi
Copy link
Contributor Author

Works, thanks for merging so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants