Update expected exception line numbers for Python 3.10.0rc1 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: I've skipped AUTHORS.txt for this tiny change but if you believe I should add myself anyway, please lemme know. |
isidentical
approved these changes
Aug 5, 2021
|
There's a small linting issue. Can you fix that? Otherwise thanks for the patch! |
It seems that upstream has fixed line numbers in some of the expections in Python 3.10.0rc1, so update the tests accordingly. This means that test_non_async_in_async() gets the correct line again, and test_default_except_error_postition() no longer suffers from the apparent off-by-one problem. This doesn't fix tests entirely with Python 3.10 but it's a step forward.
|
I'm sorry about that typo. Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that upstream has fixed line numbers in some of the expections
in Python 3.10.0rc1, so update the tests accordingly. This means that
test_non_async_in_async() gets the correct line again,
and test_default_except_error_postition() no longer suffers from
the apparent off-by-one problem.
This doesn't fix tests entirely with Python 3.10 but it's a step
forward.