Skip to content

Commit

Permalink
Merge pull request #194 from mgorny/python310
Browse files Browse the repository at this point in the history
Update expected exception line numbers for Python 3.10.0rc1
  • Loading branch information
davidhalter committed Aug 6, 2021
2 parents ed47650 + 7652d39 commit e152301
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions test/test_python_errors.py
Expand Up @@ -57,10 +57,10 @@ def test_non_async_in_async():
error, = errors
actual = error.message
assert actual in wanted
if sys.version_info[:2] < (3, 8):
if sys.version_info[:2] not in ((3, 8), (3, 9)):
assert line_nr == error.start_pos[0]
else:
assert line_nr == 0 # For whatever reason this is zero in Python 3.8+
assert line_nr == 0 # For whatever reason this is zero in Python 3.8/3.9


@pytest.mark.parametrize(
Expand Down Expand Up @@ -140,13 +140,16 @@ def _get_actual_exception(code):


def test_default_except_error_postition():
# For this error the position seemed to be one line off, but that doesn't
# really matter.
# For this error the position seemed to be one line off in Python < 3.10,
# but that doesn't really matter.
code = 'try: pass\nexcept: pass\nexcept X: pass'
wanted, line_nr = _get_actual_exception(code)
error, = _get_error_list(code)
assert error.message in wanted
assert line_nr != error.start_pos[0]
if sys.version_info[:2] >= (3, 10):
assert line_nr == error.start_pos[0]
else:
assert line_nr != error.start_pos[0]
# I think this is the better position.
assert error.start_pos[0] == 2

Expand Down

0 comments on commit e152301

Please sign in to comment.