Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix errors related to clap #158

Merged

Conversation

striezel
Copy link
Contributor

This should fix the errors from the build at
https://github.com/davidcole1340/ext-php-rs/actions/runs/3145521955/jobs/5112909446:

   Compiling clap v4.0.0
error: Unknown `#[clap(long)]` attribute (`#[arg(long)] exists)
  --> crates/cli/src/lib.rs:92:12
   |
92 |     #[clap(long)]
   |            ^^^^

error: Unknown `#[clap(long)]` attribute (`#[arg(long)] exists)
   --> crates/cli/src/lib.rs:115:12
    |
115 |     #[clap(long)]
    |            ^^^^

error: Unknown `#[clap(short)]` attribute (`#[arg(short)] exists)
   --> crates/cli/src/lib.rs:134:12
    |
134 |     #[clap(short, long)]
    |            ^^^^^

error: could not compile `cargo-php` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

These errors were probably caused by the release of clap 4.0.0 which happened a few hours ago today.

This should fix the errors from the build at
<https://github.com/davidcole1340/ext-php-rs/actions/runs/3145521955/jobs/5112909446>:

       Compiling clap v4.0.0
    error: Unknown `#[clap(long)]` attribute (`#[arg(long)] exists)
      --> crates/cli/src/lib.rs:92:12
       |
    92 |     #[clap(long)]
       |            ^^^^

    error: Unknown `#[clap(long)]` attribute (`#[arg(long)] exists)
       --> crates/cli/src/lib.rs:115:12
        |
    115 |     #[clap(long)]
        |            ^^^^

    error: Unknown `#[clap(short)]` attribute (`#[arg(short)] exists)
       --> crates/cli/src/lib.rs:134:12
        |
    134 |     #[clap(short, long)]
        |            ^^^^^

    error: could not compile `cargo-php` due to 3 previous errors
    warning: build failed, waiting for other jobs to finish...
    Error: Process completed with exit code 101.

These errors were probably caused by the release of `clap` 4.0.0
a few hours ago.
@TobiasBengtsson
Copy link
Collaborator

Looks like it was an issue in clap itself, ref: https://github.com/clap-rs/clap/releases/tag/v4.0.1 and clap-rs/clap#4276.

It does seem like arg is the new way to do things so I'll merge this anyway

@TobiasBengtsson TobiasBengtsson merged commit 81d1861 into davidcole1340:master Sep 28, 2022
@striezel striezel deleted the fix-clap-errors branch September 28, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants