Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types packages to dev dependencies #92

Closed
wants to merge 1 commit into from
Closed

Move @types packages to dev dependencies #92

wants to merge 1 commit into from

Conversation

sahariko
Copy link

@sahariko sahariko commented Feb 6, 2023

Being in dependencies means they're being installed for consumers, while they're only used for the development phase of the package, and not required when shipped.

@sahariko
Copy link
Author

sahariko commented Feb 8, 2023

@davewasmer Can you please review? 🙏

@KODerFunk
Copy link

Nice try! We've been doing this for four years now (#86, #77, #66).

@sahariko
Copy link
Author

Nice try! We've been doing this for four years now (#86, #77, #66).

Oh damn, I didn't even realize 😅

@sahariko sahariko closed this Feb 22, 2023
@sahariko sahariko deleted the dev-deps branch February 22, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sahariko @KODerFunk