Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IP address as domains #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

evsar3
Copy link

@evsar3 evsar3 commented Jan 26, 2023

This PR allow users to also use IP addresses as domain options while generating certificates.

Eg.:

import * as devcert from 'devcert'

const ssl = await devcert.certificateFor([
  'somedomain.local',
  'localhost',
  '192.168.1.2',
  '127.0.0.1'
])

PS.: It would be much less changes, but my VS Code has the organizeImports feature enable, so when I saved the files it have sorted and organized the imports. If that's a problem, I can undo this before merge (if you want).

Congratulations for the great tool. 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant