Improve checking entries in the hostfile #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetlen
requested changes
Nov 21, 2019
Comment on lines
+53
to
+61
| export function isDomainInHostFile(hostFileContents: string, domain: string): boolean { | ||
| // Do a check for a full match since a string includes can be fooled by | ||
| // a subdomain being present in the host file. | ||
| const isPresent = hostFileContents | ||
| .replace(/\s+/g, " ") | ||
| .split(" ") | ||
| .filter(item => item === domain).length > 0; | ||
| return isPresent; | ||
| } |
There was a problem hiding this comment.
This looks like pretty solid code, but I'm not 100% sure it'll work for all possible hostfile contents, such as tab characters, different encodings, or comments. Maybe it would be easier to bring in a tool like https://www.npmjs.com/package/hostile which has a well-tested hostfile parser.
There was a problem hiding this comment.
This was a pretty quick and dirty way of improving the checking. Your are right that can be fooled by domains in comments, which the previous code had a problem with as well. I'll take a look hostile and see what that looks like to bring in.
alias-mac
pushed a commit
to alias-mac/devcert
that referenced
this pull request
Feb 8, 2024
Bumps [@types/rimraf](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/rimraf) from 2.0.4 to 3.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/rimraf) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the host file check will not add a domain if a subdomain of that domain already exists.
For example if the host file contains
127.0.0.1 sub.example.comand the user is setting upexample.comit will be skipped and not added to the hostfile.