Merge pull request #83 from bmoylan/bm/struct-tags

Use %q to quote struct tag values
dave · Nov 12, 2021 · 45cc0b7 · 45cc0b7
2 parents 2abe0ee + 50f4f83
commit 45cc0b7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/jen/examples_test.go b/jen/examples_test.go
@@ -1,9 +1,8 @@
 package jen_test
 
 import (
-	"fmt"
-
 	"bytes"
+	"fmt"
 
 	. "github.com/dave/jennifer/jen"
 )
@@ -1295,6 +1294,19 @@ func ExampleTag() {
 	// }
 }
 
+func ExampleTag_withQuotesAndNewline() {
+	c := Type().Id("foo").Struct(
+		Id("A").String().Tag(map[string]string{"json": "a"}),
+		Id("B").Int().Tag(map[string]string{"json": "b", "bar": "the value of\nthe\"bar\" tag"}),
+	)
+	fmt.Printf("%#v", c)
+	// Output:
+	// type foo struct {
+	// 	A string `json:"a"`
+	// 	B int    `bar:"the value of\nthe \"bar\" tag" json:"b"`
+	// }
+}
+
 func ExampleNull_and_nil() {
 	c := Func().Id("foo").Params(
 		nil,

diff --git a/jen/tag.go b/jen/tag.go
@@ -59,7 +59,7 @@ func (t tag) render(f *File, w io.Writer, s *Statement) error {
 		if len(str) > 0 {
 			str += " "
 		}
-		str += fmt.Sprintf(`%s:"%s"`, k, v)
+		str += fmt.Sprintf(`%s:%q`, k, v)
 	}
 
 	if strconv.CanBackquote(str) {