Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump cobra version to "1.5.0" #701

Merged
merged 3 commits into from Jul 4, 2022

Conversation

CuriousCorrelation
Copy link
Contributor

@CuriousCorrelation CuriousCorrelation commented Jun 28, 2022

Description

Bumps cobra version from v1.1.3 to v1.5.0

Changes

None required as far as I can tell. Build process is successful and go run main.go works.

Issue

Closes #697

aroramrinaal
aroramrinaal previously approved these changes Jul 1, 2022
@myishay
Copy link
Contributor

myishay commented Jul 3, 2022

Hi @aroramrinaal , thanks for your contribution!

Regarding the PR title and commits, we are trying to follow conventional commits specification for the commits and perf: prefix doesn't apply to it. I suggest using build: instead.

In addition, I see the tests don't pass in the travis build.

@CuriousCorrelation
Copy link
Contributor Author

@myishay I think you wanted to ping me 👋

I think I missed those zsh completion changes because I ran tests on some other folder. This new patch should take care of that!

For reference: spf13/cobra#1690

According to the PR

#compdef _<command> <command>

enabled completions for both and _, but _ is the completion function itself and should not be completed

I have fixed the commit messages. Also divided changes:

  1. go.sum and go.mod in build:, and
  2. cmd/completion in fix:

Let me know if something needs a second look

@myishay myishay changed the title deps: Bump cobra version to "1.5.0" build: Bump cobra version to "1.5.0" Jul 3, 2022
@myishay myishay changed the title build: Bump cobra version to "1.5.0" build: bump cobra version to "1.5.0" Jul 3, 2022
@myishay
Copy link
Contributor

myishay commented Jul 3, 2022

I also updated the PR title to match the commit message

@myishay
Copy link
Contributor

myishay commented Jul 3, 2022

@myishay I think you wanted to ping me 👋

You are correct! I realized it only now 😅
so @CuriousCorrelation thank you for your contribution 😁

@CuriousCorrelation
Copy link
Contributor Author

CuriousCorrelation commented Jul 3, 2022

You are correct! I realized it only now

No worries at all!

Everything should be good to go, although feel free to let me know if there are any changes I should make.

@myishay
Copy link
Contributor

myishay commented Jul 4, 2022

LGTM!
I have updated the branch to the latest changes and will merge this soon

@myishay myishay merged commit 3fba04a into datreeio:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump cobra version to 1.5.0
3 participants