Fix Travis build command #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build environment was originally broken, and no release environment existed. This allows for the Python dependencies for `release.py` to be satisfied automatically as part of invoking the tox command.
Moving to a model where dependencies are provided by `tox` as needed where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like #971 is no longer sending out webhooks or something. Creating this new PR to debug the issue where Travis wasn't failing even though the
buildcommand wasn't building any files.The issue is that the current shell test
[ ! -e "dist/*.whl" ]is expanding to nothing if no build happens, and I guess[ -ethinks I'm asking if "nothing" exists or something. Switching over to usingfind.