Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom ParserError class in parser exceptions #881

Merged
merged 4 commits into from Apr 23, 2019
Merged

Use custom ParserError class in parser exceptions #881

merged 4 commits into from Apr 23, 2019

Commits on Apr 23, 2019

  1. Use custom ParserError class in parser 

    This gives a nicer string representation while retaining access to the
input string in the exception arguments.
    @gfyoung @pganssle
    gfyoung authored and pganssle committed Apr 23, 2019
    Copy the full SHA
    7aded55 View commit details
    Browse the repository at this point in the history

  2. Add xfailing test for ParserError

    @pganssle
    pganssle committed Apr 23, 2019
    Copy the full SHA
    3dc323b View commit details
    Browse the repository at this point in the history

  3. Wrap ValueError in ParserError 

    Ensures that ValueErrors raised when building the datetime from an
already-parsed string will be raised as ParserError as well.
    @pganssle
    pganssle committed Apr 23, 2019
    Copy the full SHA
    31e8c66 View commit details
    Browse the repository at this point in the history

  4. Convert all parser raises tests to use ParserError 

    ParserError is a subclass of ValueError, so this just makes the tests
stricter, and this can be considered a backwards-compatible change.
    @pganssle
    pganssle committed Apr 23, 2019
    Copy the full SHA
    f764c8a View commit details
    Browse the repository at this point in the history