New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock setuptools_scm #1349
Unblock setuptools_scm #1349
Conversation
28b49ff
to
85495ee
Compare
Unfortunately this doesn't work, because the issue is that we build the tarball and the wheel once, using some arbitrary Python version, targeting all Python versions. If we wanted to continue using Unfortunately (and ironically), Instead, for future releases I plan to remove |
Couldn't we use |
Blocking current setuptools releases has blocked building on *current* Python environments in the name of compatibility with EOL's 2.x releases. Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
39e5f53
to
2d73f7b
Compare
If the issue is what ends up in the wheel, then setup your wheel builder to use the version you want to use, don't block everybody else from building with current tooling. The solution in this PR should work for the source dist tarball for anybody building it.
That's up to you. In general using vcs/scm versioning modules is a good thing for distros because it allows them to build devel packages from Git HEAD with sensible version data. It also usually gives an extra channel that works for builds (being able to use Git archive sources instead of source dist tarballs while still getting the expected version info). I package hundreds of Python libraries for Arch and usually having setuptools_scm (or equivalent for other Python build systems) is usually just fine. I don't think you necessary need to give up on those advantages. |
If you would like to build and deploy something different from the standard version of Thank you for your contribution. |
If you build this PR with current tooling, you end up with a package that claims to support py2 but doesn't support py2. |
I'm not trying to "deploy" or "generate releases". I'm trying to build and install against system-provided dependencies. In other words anybody not operating on a per-project silo basis such as venvs or whatever is going to have trouble with this not being addressed. I'm not asserting this PR is the correct fix, I'm just asserting that there is an issue with different scope than what the pushback to this PR seems to be assuming. |
This should un-bork what #1346 broke for folks that are actually in current instead of EOL Python envirenments.