Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7 #1345

Closed
wants to merge 4 commits into from
Closed

Conversation

pquentin
Copy link
Contributor

@pquentin pquentin commented Mar 1, 2024

Summary of changes

dateutil 2.9.0 accidentally dropped support for Python<3.6 support because setuptools-scm included a type hint in _version.py. This seemed like a good opportunity to remove Python 2.7 support.

  • I've removed six in the process, which has 90% of the downloads of dateutil, suggesting dateutil is currently the main package keeping six popular.
  • I'm happy to include follow-up pull requests for later versions of Python.
  • Should I run pyupgrade, even if this will make the diff more verbose?

Closes #1344 (but the type hint will have to be removed for Python 3.3 to 3.5 for the issue to be really closed).

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@pganssle pganssle closed this Mar 1, 2024
@pquentin
Copy link
Contributor Author

pquentin commented Mar 1, 2024

@hugovk pointed me to #1130 (comment) which explains why the pull request was closed. It was really hidden (I did search for it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.9.0 is not compatible with python 2
2 participants