Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for Python 3.12 #1317

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jack-mcivor
Copy link

@jack-mcivor jack-mcivor commented Nov 7, 2023

Summary of changes

Add explicit support for Python 3.12

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@jack-mcivor jack-mcivor changed the title Add trove classifier for 3.12 Add support for Python 3.12 Nov 7, 2023
@jack-mcivor jack-mcivor changed the title Add support for Python 3.12 Add explicit support for Python 3.12 Nov 7, 2023
@cclauss
Copy link
Contributor

cclauss commented Jan 19, 2024

Please rebase so we can see if the tests now pass.

@goncalossilva
Copy link

Will this be going in anytime soon? Can I help to see it through? Our update to Python 3.12 is currently blocked on this. 🙏

@edgarrmondragon
Copy link

Will this be going in anytime soon? Can I help to see it through? Our update to Python 3.12 is currently blocked on this. 🙏

@goncalossilva This PR only adds metadata and dateutil is already compatible with Python 3.12, so this shouldn't block any downstream updates :)

@goncalossilva
Copy link

We turn all warnings into errors during testing, so we can't cope with:

../../../.cache/pypoetry/virtualenvs/ist-libs-RGqaVcAI-py3.12/lib/python3.12/site-packages/dateutil/tz/tz.py:37: in
EPOCH = datetime.datetime.utcfromtimestamp(0)
E DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).

I realize that's our doing and also that I missed the 2.9.0 release just a few days ago which addresses this, so we can go ahead and update regardless of this particular ticket. Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants