Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): add Python 3.12 in test matrix #1300

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stegayet
Copy link

@stegayet stegayet commented Aug 5, 2023

Summary of changes

Closes #1301.

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@stegayet stegayet force-pushed the chore/add-python-3.12-to-ci branch 2 times, most recently from f861175 to 02d5991 Compare August 5, 2023 23:06
@stegayet
Copy link
Author

stegayet commented Aug 5, 2023

I seems this work is already ongoing in #1290.

@hugovk
Copy link
Contributor

hugovk commented Aug 26, 2023

@stegayet This PR has more of the necessary parts than #1290.

I recommend adding this, it will allow the 3.12 jobs to run, regardless of the unrelated 2.7 failures:

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
index b02427c..4e68c0a 100644
--- a/.github/workflows/validate.yml
+++ b/.github/workflows/validate.yml
@@ -11,6 +11,7 @@ on:
 jobs:
   test:
     strategy:
+      fail-fast: false
       matrix:
         python-version: [
           "2.7",

@cbrnr
Copy link

cbrnr commented Oct 4, 2023

Python 2.7 has been removed from the runners on June 19. There are two options:

  1. Remove tests on Python 2.7
  2. Create custom solution to continue running tests on Python 2.7

Since Python 2.7 is EOL since 2020, I'd recommend the first option.

@hugovk
Copy link
Contributor

hugovk commented Oct 4, 2023

I agree but let's not discuss Python 2.7 here, instead please see #653 and #1291. The failing 2.7 CI job need not delay this PR.

@cbrnr
Copy link

cbrnr commented Oct 4, 2023

All other jobs are green, is there anything else that's missing?

@stegayet stegayet marked this pull request as ready for review October 5, 2023 07:00
@ThomasWaldmann
Copy link

ThomasWaldmann commented Oct 9, 2023

LGTM! Would be good to merge this.

Python 3.12 with dateutil 2.8.2 shows a deprecation warning:

.tox/py312-fuse3/lib/python3.12/site-packages/dateutil/tz/tz.py:37: 16 warnings
/vagrant/borg/borg/.tox/py312-fuse3/lib/python3.12/site-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
     EPOCH = datetime.datetime.utcfromtimestamp(0)

BTW, the setuptools_scm related failure seen in the test run might go away with 8.0.4.

@cclauss
Copy link
Contributor

cclauss commented Jan 19, 2024

Please rebase so we can see if the tests now pass.

@stegayet stegayet force-pushed the chore/add-python-3.12-to-ci branch 2 times, most recently from b0f3206 to ea5af10 Compare January 19, 2024 10:17
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.12 to CI
6 participants