New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): add Python 3.12 in test matrix #1300
base: master
Are you sure you want to change the base?
Conversation
f861175
to
02d5991
Compare
I seems this work is already ongoing in #1290. |
@stegayet This PR has more of the necessary parts than #1290. I recommend adding this, it will allow the 3.12 jobs to run, regardless of the unrelated 2.7 failures: diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
index b02427c..4e68c0a 100644
--- a/.github/workflows/validate.yml
+++ b/.github/workflows/validate.yml
@@ -11,6 +11,7 @@ on:
jobs:
test:
strategy:
+ fail-fast: false
matrix:
python-version: [
"2.7", |
Python 2.7 has been removed from the runners on June 19. There are two options:
Since Python 2.7 is EOL since 2020, I'd recommend the first option. |
All other jobs are green, is there anything else that's missing? |
LGTM! Would be good to merge this. Python 3.12 with dateutil 2.8.2 shows a deprecation warning:
BTW, the setuptools_scm related failure seen in the test run might go away with 8.0.4. |
Please rebase so we can see if the tests now pass. |
b0f3206
to
ea5af10
Compare
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ea5af10
to
26f97e9
Compare
Summary of changes
Closes #1301.
Pull Request Checklist