Add tests #3559
Merged
Add tests #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossnocorp
requested changes
Nov 2, 2023
src/constructFrom/test.ts
Outdated
Comment on lines
39
to
47
| it('should create a new custom Date instance using a number as the reference date', () => { | ||
| class CustomDate extends Date {} | ||
| const referenceDate = new CustomDate(1635158400000) // October 25, 2023 | ||
| const value = new CustomDate('2023-10-26T12:00:00') | ||
|
|
||
| const result = constructFrom(referenceDate, value) | ||
|
|
||
| assert.ok(result instanceof CustomDate) | ||
| assert.deepStrictEqual(result, value) | ||
| assert.strictEqual(result.constructor, CustomDate) | ||
| }) |
There was a problem hiding this comment.
This case is equal to the previous one, it doesn't matter for the function how you create CustomDate.
For the symmetry, you better add test case where both referenceDate and value are numbers.
|
To fix the tests, please rebase to main |
tan75
force-pushed
the
constructFrom-add-tests
branch
from
01e498a
to
d86a793
Compare
|
Can you please rebase again? 🙏 |
kossnocorp
force-pushed
the
constructFrom-add-tests
branch
from
737f9ba
to
fceef14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.