Add @name in constants jsdocs to fix type generation duplication
#3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2022
|
Released as https://github.com/date-fns/date-fns/releases/tag/v2.29.1 Thank you so much @fturmel! |
|
@leshakoss You're welcome. Shoutout to @tom-spikeglobal for the early issue report before 2.29 was even released. This is something the CI tests should've caught imo, I invite you to look at some old PRs I opened to improve the linter and type checks: #2948 #2949 Let me know in the PRs themselves if you're interested, and we can fix the current conflicts, etc. Some of the linter rules I added (fixing bad import paths, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3119