Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed constants TS typings #2941

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Fixed constants TS typings #2941

merged 3 commits into from
Jun 23, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Feb 1, 2022

Re-added src/constants/index.d.ts and added module definitions to typings.d.ts

fturmel
fturmel requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@fturmel fturmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I also had noticed that the constants .d.ts file wasn't automatically generated.

scripts/build/_lib/typings/typeScript.js Outdated Show resolved Hide resolved
@fturmel fturmel mentioned this pull request Feb 3, 2022
Open
leshakoss
leshakoss approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@leshakoss leshakoss merged commit 26ac7f2 into date-fns:master Jun 23, 2022
@JuanM04 JuanM04 deleted the constant-typings branch June 23, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leshakoss leshakoss leshakoss approved these changes

@fturmel fturmel fturmel approved these changes

Assignees
No one assigned
Labels
🐜 Bug fix TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JuanM04 @leshakoss @fturmel