-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remaining locales migration to TypeScript #2898
Conversation
hi @date-fns/i18n-lt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this impressive work! 🚀 🙏
You're welcome! Thanks for reviewing it so quickly. |
@leshakoss date-fns/date-fns-typescriptify#204 |
@leshakoss also I had migrated |
Let's start the new year with a bang! Hope this isn't too unwieldy, but I opted for one migration per commit (easier reviews) and one PR as to not flood the project with 50+ individual PRs.
I worked with diffs of the
en-US
locale for every single file to try to keep the reference implementation's code shape when possible.Overview
fil
which has been broken for a while, anduk
which already had an approved PRnn
andsv
locales supportoptions.onlyNumeric
informatDistance
, so I added it to theFormatDistanceOptions
typeSnapshot.md file changes (6 locales total)
hr
,ka
,sr
andsr-Latn
ka
formatDuration
ofkk
lt
locale'sformatDistance
that prevented it from using future tense with suffixes. I don't speak the language, so could someone confirm this is OK? Hard-coding this constant tofalse
reverts to the old behavior. @date-fns/i18n-ltfixes date-fns/date-fns-typescriptify#150
fixes date-fns/date-fns-typescriptify#151
fixes date-fns/date-fns-typescriptify#152
fixes date-fns/date-fns-typescriptify#153
fixes date-fns/date-fns-typescriptify#155
fixes date-fns/date-fns-typescriptify#164
fixes date-fns/date-fns-typescriptify#165
fixes date-fns/date-fns-typescriptify#166
fixes date-fns/date-fns-typescriptify#167
fixes date-fns/date-fns-typescriptify#219
fixes date-fns/date-fns-typescriptify#173
fixes date-fns/date-fns-typescriptify#174
fixes date-fns/date-fns-typescriptify#175
fixes date-fns/date-fns-typescriptify#177
fixes date-fns/date-fns-typescriptify#220
fixes date-fns/date-fns-typescriptify#178
fixes date-fns/date-fns-typescriptify#179
fixes date-fns/date-fns-typescriptify#184
fixes date-fns/date-fns-typescriptify#185
fixes date-fns/date-fns-typescriptify#186
fixes date-fns/date-fns-typescriptify#188
fixes date-fns/date-fns-typescriptify#189
fixes date-fns/date-fns-typescriptify#190
fixes date-fns/date-fns-typescriptify#191
fixes date-fns/date-fns-typescriptify#192
fixes date-fns/date-fns-typescriptify#193
fixes date-fns/date-fns-typescriptify#194
fixes date-fns/date-fns-typescriptify#197
fixes date-fns/date-fns-typescriptify#195
fixes date-fns/date-fns-typescriptify#196
fixes date-fns/date-fns-typescriptify#197
fixes date-fns/date-fns-typescriptify#198
fixes date-fns/date-fns-typescriptify#200
fixes date-fns/date-fns-typescriptify#199
fixes date-fns/date-fns-typescriptify#201
fixes date-fns/date-fns-typescriptify#202
fixes date-fns/date-fns-typescriptify#206
fixes date-fns/date-fns-typescriptify#205
fixes date-fns/date-fns-typescriptify#207
fixes date-fns/date-fns-typescriptify#208
fixes date-fns/date-fns-typescriptify#209
fixes date-fns/date-fns-typescriptify#210
fixes date-fns/date-fns-typescriptify#212
fixes date-fns/date-fns-typescriptify#214
fixes date-fns/date-fns-typescriptify#215
fixes date-fns/date-fns-typescriptify#216
fixes date-fns/date-fns-typescriptify#217