Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining locales migration to TypeScript #2898

Merged
merged 60 commits into from
Jan 10, 2022

Conversation

fturmel
Copy link
Member

@fturmel fturmel commented Jan 5, 2022

Let's start the new year with a bang! Hope this isn't too unwieldy, but I opted for one migration per commit (easier reviews) and one PR as to not flood the project with 50+ individual PRs.

I worked with diffs of the en-US locale for every single file to try to keep the reference implementation's code shape when possible.

Overview

  • all remaining locales were migrated to TS except for fil which has been broken for a while, and uk which already had an approved PR
  • fixed a few previously migrated locales that had type issues
  • the nn and sv locales support options.onlyNumeric in formatDistance, so I added it to the FormatDistanceOptions type

Snapshot.md file changes (6 locales total)

  • Fixed issue parsing months in hr, ka, sr and sr-Latn
  • Fixed issue parsing day of week in ka
  • Fixed weeks support in formatDuration of kk
  • I believe I fixed a code issue in the lt locale's formatDistance that prevented it from using future tense with suffixes. I don't speak the language, so could someone confirm this is OK? Hard-coding this constant to false reverts to the old behavior. @date-fns/i18n-lt

fixes date-fns/date-fns-typescriptify#150
fixes date-fns/date-fns-typescriptify#151
fixes date-fns/date-fns-typescriptify#152
fixes date-fns/date-fns-typescriptify#153
fixes date-fns/date-fns-typescriptify#155
fixes date-fns/date-fns-typescriptify#164
fixes date-fns/date-fns-typescriptify#165
fixes date-fns/date-fns-typescriptify#166
fixes date-fns/date-fns-typescriptify#167
fixes date-fns/date-fns-typescriptify#219
fixes date-fns/date-fns-typescriptify#173
fixes date-fns/date-fns-typescriptify#174
fixes date-fns/date-fns-typescriptify#175
fixes date-fns/date-fns-typescriptify#177
fixes date-fns/date-fns-typescriptify#220
fixes date-fns/date-fns-typescriptify#178
fixes date-fns/date-fns-typescriptify#179
fixes date-fns/date-fns-typescriptify#184
fixes date-fns/date-fns-typescriptify#185
fixes date-fns/date-fns-typescriptify#186
fixes date-fns/date-fns-typescriptify#188
fixes date-fns/date-fns-typescriptify#189
fixes date-fns/date-fns-typescriptify#190
fixes date-fns/date-fns-typescriptify#191
fixes date-fns/date-fns-typescriptify#192
fixes date-fns/date-fns-typescriptify#193
fixes date-fns/date-fns-typescriptify#194
fixes date-fns/date-fns-typescriptify#197
fixes date-fns/date-fns-typescriptify#195
fixes date-fns/date-fns-typescriptify#196
fixes date-fns/date-fns-typescriptify#197
fixes date-fns/date-fns-typescriptify#198
fixes date-fns/date-fns-typescriptify#200
fixes date-fns/date-fns-typescriptify#199
fixes date-fns/date-fns-typescriptify#201
fixes date-fns/date-fns-typescriptify#202
fixes date-fns/date-fns-typescriptify#206
fixes date-fns/date-fns-typescriptify#205
fixes date-fns/date-fns-typescriptify#207
fixes date-fns/date-fns-typescriptify#208
fixes date-fns/date-fns-typescriptify#209
fixes date-fns/date-fns-typescriptify#210
fixes date-fns/date-fns-typescriptify#212
fixes date-fns/date-fns-typescriptify#214
fixes date-fns/date-fns-typescriptify#215
fixes date-fns/date-fns-typescriptify#216
fixes date-fns/date-fns-typescriptify#217

@tan75
Copy link
Contributor

tan75 commented Jan 5, 2022

Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this impressive work! 🚀 🙏

@tan75 tan75 requested a review from a team January 5, 2022 22:59
@fturmel
Copy link
Member Author

fturmel commented Jan 6, 2022

You're welcome! Thanks for reviewing it so quickly.

@leshakoss leshakoss mentioned this pull request Jan 8, 2022
26 tasks
@leshakoss leshakoss merged commit 749f4ea into date-fns:master Jan 10, 2022
@fturmel fturmel deleted the PR/locales-ts-migration branch January 10, 2022 13:10
@fturmel
Copy link
Member Author

fturmel commented Jan 10, 2022

@leshakoss gd and sl were also migrated in this PR, you can close:

date-fns/date-fns-typescriptify#204
date-fns/date-fns-typescriptify#172

@fturmel
Copy link
Member Author

fturmel commented Jan 10, 2022

@leshakoss also I had migrated ru in this PR too, so you can probably close #2895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants