Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added it-CH locale #2886

Merged
merged 2 commits into from
Jan 10, 2022
Merged

added it-CH locale #2886

merged 2 commits into from
Jan 10, 2022

Conversation

maic66
Copy link
Contributor

@maic66 maic66 commented Dec 28, 2021

Please be patient if I did some mistakes, it's my first PR contribution.

fturmel
fturmel requested changes Dec 28, 2021
View reviewed changes
Copy link
Member

@fturmel fturmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See my comment about the missing jsdoc annotation.

src/locale/it-CH/index.ts Show resolved Hide resolved
This was linked to issues Dec 28, 2021
Migrate locale/it to Typescript #2804
Closed
Swiss Italian (it-CH) language support #2802
Closed
maic66
maic66 commented Dec 29, 2021
View reviewed changes
Copy link
Contributor Author

@maic66 maic66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added missing jsdoc annotation

@leshakoss leshakoss merged commit 214413c into date-fns:master Jan 10, 2022
@Spinnenzunge
Copy link

Thank you very much 💋

@maic66
Copy link
Contributor Author

maic66 commented Feb 23, 2022

I've seen this was a late merge and it's still not reflected in npm package.
How does it work?

@fturmel
Copy link
Member

fturmel commented Feb 24, 2022

@maic66 there just hasn't been an official release since the PR was merged. I don't know for sure, but it seems like there is only one task holding off the next release #2887

@maic66
Copy link
Contributor Author

maic66 commented May 10, 2022

Hi all. I updated my npm packages but this commit is still not present.
Has somebody an explanation for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fturmel fturmel fturmel approved these changes

Assignees
No one assigned
Labels
🌏 I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate locale/it to Typescript Swiss Italian (it-CH) language support
4 participants
@maic66 @Spinnenzunge @fturmel @leshakoss