Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ordinal number modifier in long formats in Russian #2478

Merged
merged 2 commits into from May 28, 2021
Merged

Don't use ordinal number modifier in long formats in Russian #2478

merged 2 commits into from May 28, 2021

Conversation

jwbth
Copy link
Contributor

@jwbth jwbth commented May 18, 2021

Using ordinal number modifier with dates in Russian is strongly discouraged by all authoritative sources:

  • http://new.gramota.ru/spravka/letters/87-rubric-99 (Gramota.ru, the top source for Russian language rules and such): "Наращение не используется: [...] При записи календарных чисел: 22 марта 2003 года, 1 апреля, 10 января. Не: 22-го марта 2003-го года, 1-го апреля, 10-е января." ("Modifier is not used: [...] When writing calendar numbers: [Examples]".)
  • http://www.evartist.narod.ru/text1/31.htm (Rosental's guidebook): "Недопустимы наращения при количественных числительных, обозначениях дат, а также при римских цифрах: из 25 участников, 24 мая, VII съезд." ("Modifiers are not allowed for quantitative numerals, date designations, or Roman numerals: [Examples].")

Using ordinal number modifier with dates in Russian is *strongly discouraged* by all authoritative sources:
* http://new.gramota.ru/spravka/letters/87-rubric-99: "Наращение не используется: [...] При записи календарных чисел: 22 марта 2003 года, 1 апреля, 10 января. Не: 22-го марта 2003-го года, 1-го апреля, 10-е января." ("Modifier is not used: [...] When writing calendar numbers: [Examples]".)
* http://www.evartist.narod.ru/text1/31.htm: "Недопустимы наращения при количественных числительных, обозначениях дат, а также при римских цифрах: из 25 участников, 24 мая, VII съезд." ("Modifiers are not allowed for quantitative numerals, date designations, or Roman numerals: [Examples].")
@tan75 tan75 self-assigned this May 25, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
The changes suggested in this PR correspond with CLRD
CLDR Russian

@tan75
Copy link
Contributor

tan75 commented May 25, 2021

hi @jwbth
the locale snapshot test failed - could you please run yarn locale-snapshots and commit the results?

tan75
tan75 previously requested changes May 25, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn locale-snapshots and commit the results
This is done now.

@kossnocorp kossnocorp dismissed tan75’s stale review May 28, 2021 04:43

The requested change is done

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thank you a lot ♥

@kossnocorp kossnocorp merged commit deee6a3 into date-fns:master May 28, 2021
@jwbth jwbth deleted the patch-1 branch May 28, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants