Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new locale: Occitan (closes #2061) #2106

Merged
merged 16 commits into from
Jan 10, 2022
Merged

new locale: Occitan (closes #2061) #2106

merged 16 commits into from
Jan 10, 2022

Conversation

Mejans
Copy link
Contributor

@Mejans Mejans commented Nov 26, 2020 •
edited by leshakoss

Hello!
This is my first PR here. I struggle a bit to end it...
For the "match" part and a JS function called ordinalNumber in Localize.
If someone could give me some hints.

Thanks!

closes #2061

@Mejans Mejans changed the title [WIP] new locale: Occitan new locale: Occitan Dec 6, 2020
@Mejans
Copy link
Contributor Author

Mejans commented Feb 20, 2021

Hello @kossnocorp @rikkalo may I ask who I can contact to get some help in adding a new locale?
Thanks!

@rikkalo
Copy link
Contributor

rikkalo commented Feb 21, 2021

Hi, @Mejans!
Thanks for your PR 👍
You can ask me

@Mejans
Copy link
Contributor Author

Mejans commented Feb 21, 2021

Thanks @rikkalo ,
well I'm not a JavaScript expert, I don't know how to end this PR so it can be added =/

@kossnocorp
Copy link
Member

@Mejans please run yarn build-snapshots and commit the results. I would also appreciate if you can format the code using Prettier.

@tan75
Copy link
Contributor

tan75 commented Apr 14, 2021

Hi @Mejans
thank you for this PR!
The code is failing on the below error - could you please double-check it?
image

@tan75
Copy link
Contributor

tan75 commented Apr 14, 2021

@Mejans
as well, please run yarn locale-snapshots to update snapshots.

tan75
tan75 requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments. Let us know if you have any questions!

@tan75 tan75 self-assigned this Apr 14, 2021
@Mejans
Copy link
Contributor Author

Mejans commented Apr 16, 2021

Please address my comments. Let us know if you have any questions!

Hello! Thanks, I've just made some changes, it was thought with PHP on mind, my bad.
I'm not really good at Javascript, I hope this passes the test!

@tan75 tan75 mentioned this pull request Oct 17, 2021
Closed
@tan75
Copy link
Contributor

tan75 commented Oct 17, 2021

Hi @Mejans
apologies for the delay - the tests are failing because this locale is missing the below file:
_lib/match/index.js

The instructions on how to create this file are below:
https://date-fns.org/v2.25.0/docs/I18n-Contribution-Guide#match

Could you please have a look into this again?

@Mejans
Copy link
Contributor Author

Mejans commented Oct 17, 2021

Hello @tan75 yes sure, I will try again, I would be so happy to see my language merged into the project.
Thanks

@tan75
Copy link
Contributor

tan75 commented Nov 23, 2021

TODO: delete the branch #2698

Mejans and others added 11 commits January 5, 2022 11:13
@Mejans @fturmel
Create index.js
d0818f1
@Mejans @fturmel
Create index.js
f32b68f
@Mejans @fturmel
Create index.js
78c15f2
@Mejans @fturmel
Create index.js
7d121d4
@Mejans @fturmel
Create index.js
8e80756
@Mejans @fturmel
Update index.js
942bea4 
Function ordinalNumber should return:
if unit is year, week, hour, minute or second
 => 1èra with 1, 2nda with 2 and in any other case Xena (X being a number)
else
=> 1èr with 1, 2nd with 2 and in any other case Xen (X being a number)
@Mejans @fturmel
Better function
a2e3255
@Mejans @fturmel
Update index.js
d18b593
@Mejans @fturmel
Update index.js
541426d
@Mejans @fturmel
Update index.js
f6b1b6b
@fturmel
finish oc locale
6d93653
@fturmel
Copy link
Member

fturmel commented Jan 5, 2022

Hope that's OK, trying to help push this to the finish line.

  • rebased onto current master
  • converted to TypeScript
  • created the match file as best as I could by referencing the work in localize. I don't speak the language but do speak French, so it wasn't too hard to track progress

@Mejans Can you review the work and the snapshot.md file, and let us know how it looks?

@Mejans
Copy link
Contributor Author

Mejans commented Jan 5, 2022

@fturmel d'accord :) Merci beaucoup, je vais regarder les fichiers pour vous dire si ça me semble bon. Encore merci

Mejans
Mejans commented Jan 5, 2022
View reviewed changes
src/locale/oc/snapshot.md Outdated Show resolved Hide resolved
Mejans
Mejans commented Jan 5, 2022
View reviewed changes
src/locale/oc/snapshot.md Outdated Show resolved Hide resolved
Mejans
Mejans commented Jan 5, 2022
View reviewed changes
src/locale/oc/snapshot.md Outdated Show resolved Hide resolved
@fturmel
Copy link
Member

fturmel commented Jan 5, 2022 •
edited

@Mejans It might help if you compare against the more thoroughly tested outputs of the en-US or fr locales

@Mejans
Copy link
Contributor Author

Mejans commented Jan 5, 2022

sure ah ah ah, will avoid questioning ah ah.
Can I do it for tomorrow?

@fturmel
Copy link
Member

fturmel commented Jan 5, 2022

Can I do it for tomorrow?

Of course, no rush. This PR was dormant for over a year. I'm just stepping in to help a bit.

Ce serait dommage de perdre tout ce travail!

@Mejans
Copy link
Contributor Author

Mejans commented Jan 5, 2022

Merci de l'avoir réveillé surtout ! Ça me faisait un peu de peine de savoir que j'avais une PR en attente, mais je ne savais pas par quoi commencer. 1 000 mercis

@Mejans
Copy link
Contributor Author

Mejans commented Jan 6, 2022

Done!

@fturmel
Copy link
Member

fturmel commented Jan 6, 2022

Thanks for reviewing all this, last changes were made. Seems like we're good to go?

@fturmel fturmel requested a review from tan75 January 6, 2022 17:47
@Mejans
Copy link
Contributor Author

Mejans commented Jan 6, 2022

Yes, brilliant, many thanks!

@leshakoss leshakoss mentioned this pull request Jan 7, 2022
Closed
26 tasks
@leshakoss leshakoss changed the title new locale: Occitan new locale: Occitan (closes #2061) Jan 8, 2022
@leshakoss leshakoss merged commit 7a60173 into date-fns:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fturmel fturmel fturmel approved these changes

@tan75 tan75 Awaiting requested review from tan75

Assignees

@tan75 tan75

Labels
🎉 Feature 🌏 I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occitan language support
6 participants
@Mejans @rikkalo @kossnocorp @tan75 @fturmel @leshakoss