Make differenceInBusinessDays return NaN instead of Invalid Date #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossnocorp
changed the title
kossnocorp
requested changes
Oct 27, 2020
| "name": "date-fns", | ||
| "version": "DON'T CHANGE; IT'S SET AUTOMATICALLY DURING DEPLOYMENT; ALSO, USE YARN FOR DEVELOPMENT", | ||
| "lockfileVersion": 1 | ||
| } |
There was a problem hiding this comment.
Please remove the file from the PR.
Comment on lines
+44
to
+46
| // fix for issue # 2012 | ||
| // returning undefined to fix issue of returning a Date when either date is invalid | ||
| if (!isValid(dateLeft) || !isValid(dateRight)) return NaN |
There was a problem hiding this comment.
No need for the comment.
Suggested change
| // fix for issue # 2012 | |
| // returning undefined to fix issue of returning a Date when either date is invalid | |
| if (!isValid(dateLeft) || !isValid(dateRight)) return NaN | |
| if (!isValid(dateLeft) || !isValid(dateRight)) return NaN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw there were already tests in place for this issue. I got them to pass by changing the return from new Date(NaN), which returns invalid date, to NaN.