Fixed greek grammar for Saturday on formatRelative #1930
Conversation
| @@ -4,7 +4,7 @@ var dateFormats = { | |||
| full: 'EEEE, d MMMM y', | |||
| long: 'd MMMM y', | |||
| medium: 'd MMM y', | |||
| short: 'd/M/yy' | |||
| short: 'd/M/y' | |||
There was a problem hiding this comment.
I'm pretty sure this change is not correct. y does not provide shorter result:
> dateFns.format(new Date(), 'd/M/y')
'31/8/2020'
> dateFns.format(new Date(), 'd/M/yy')
'31/8/20'
I know it's confusing, but it's needed for dates like 5 AD:
> const date = new Date()
undefined
> date.setFullYear(5)
-61988407055185
> dateFns.format(date, 'd/M/y')
'31/8/5'
> dateFns.format(date, 'd/M/yy')
'31/8/05'
There was a problem hiding this comment.
Sorry, about that. I just committed the locale snapshot. The change in formatRelative was intentional, but I forgot to mention it. I didn't want for the year component to become shorter, I just think that the full year format is more readable (and more commonly used in Greece).
There was a problem hiding this comment.
Please rollback the change and use a custom format in your code. d/M/yy corresponds to the standard: https://unicode-org.github.io/cldr-staging/charts/37/summary/el.html#57dac0d1b36c1261
There was a problem hiding this comment.
I didn't know that, but I can assure you that the vast majority of people in Greece write the year as four digits. Do you want me change it to yyyy or roll it back to yy?
There was a problem hiding this comment.
Sorry, I can't rely on subjective feelings. It's already challenging to support locales as I can only speak two languages, but date-fns supports dozens. Without a standard to consult, this will turn into chaos.
If you are 100% sure that the standard is incorrect, I will be happy to reconsider, but we'll have to do it in a separate pull-request with a review from other native speakers.
Please revert to yy.
I'm about to ship a new version, and if you can make this change and commit once again updated snapshot right now, it will go live right away.
| @@ -4,7 +4,7 @@ var dateFormats = { | |||
| full: 'EEEE, d MMMM y', | |||
| long: 'd MMMM y', | |||
| medium: 'd MMM y', | |||
| short: 'd/M/yy' | |||
| short: 'd/M/y' | |||
There was a problem hiding this comment.
Please rollback the change and use a custom format in your code. d/M/yy corresponds to the standard: https://unicode-org.github.io/cldr-staging/charts/37/summary/el.html#57dac0d1b36c1261
There was a problem hiding this comment.
Please rollback the change and use a custom format in your code. d/M/yy corresponds to the standard: https://unicode-org.github.io/cldr-staging/charts/37/summary/el.html#57dac0d1b36c1261
No description provided.