New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifies that strings are still allowed as arguments, but not when a date is expected #1910

Merged

kossnocorp merged 1 commit into date-fns:master from bradevans:clarification

Aug 31, 2020

Contributor

bradevans commented Aug 19, 2020

After upgrading to v2 I kept seeing this warning. I just felt that it was somewhat misleading and could be clarified.


          Clarifies that strings are still allowed as arguments, but not when a…

eccd703

… date is expected.

kossnocorp approved these changes

View reviewed changes

Member

kossnocorp left a comment

Sounds good to me, thanks!

kossnocorp added the ⛴ Ship it! label

kossnocorp merged commit 12ad743 into date-fns:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment