Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

he locale: use shorter Hebrew alternative for "about" #1893

Merged
merged 2 commits into from Aug 27, 2020

Conversation

yotamofek
Copy link
Contributor

This PR changes all instances of the Hebrew word "בערך" to the prefix "כ" which has the exact same meaning, is much shorter, and actually sounds a little better to native Hebrew speakers (I polled around with my friends and family, obviously this is a subjective statement but I think it's not a harmful assumption).

I checked on the unicode charts and there is no translation of the word "about" anywhere,
and here is an article from the Hebrew Academy (which in Israel holds the mandate for regulating the Hebrew language) which states that bove "בערך" and "כ-" can be used interchangeably: https://hebrew-academy.org.il/2020/05/27/%D7%91%D7%A2%D7%A8%D7%9A-%D7%9B%D6%BE/

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't read it, but it sounds good to me! Thank you a lot for your contribution and patient waiting. I Will ship it soon!

@yotamofek
Copy link
Contributor Author

Thank you, for this amazing library!

@kossnocorp kossnocorp merged commit a0d70e3 into date-fns:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants