Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requiredArgs error message #1674

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/_lib/requiredArgs/index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
export default function requiredArgs(required, args) {
if (args.length < required) {
throw new TypeError(
required + ' argument' + required > 1
? 's'
: '' + ' required, but only ' + args.length + ' present'
required +
' argument' +
(required > 1 ? 's' : '') +
' required, but only ' +
args.length +
' present'
)
}
}
37 changes: 37 additions & 0 deletions src/_lib/requiredArgs/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// @flow
/* eslint-env mocha */

import assert from 'power-assert'
import requiredArgs from '.'

describe('requiredArgs', function() {
function wrapperFn(required) {
// $ExpectedMistake
return function() {
requiredArgs(required, arguments)
}
}
const twoArgsRequired = wrapperFn(2)

context('with correct number of passed arguments', function() {
it('does not throw an error', function() {
assert.doesNotThrow(() => twoArgsRequired(1, 2))
})
})

context('with wrong number of arguments', function() {
it('throws correct error message', function() {
assert.throws(
function() {
twoArgsRequired(1)
},
function(err) {
return (
err instanceof TypeError &&
err.message === '2 arguments required, but only 1 present'
)
}
)
})
})
})