fix bug in fn formatRelative: next/last prefix shows depends on the day in same week or not #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cubicwork thank you for your work! Please resolve the conflicts so I can merge the PR. @date-fns/i18n-zh-cn please take a look |
|
@kossnocorp sorry about that, conflicts solved. |
|
@cubicwork no worries. I just pushed a fix for CI, once it's green I'm going to merge it. Thank you again! |
This was referenced Mar 16, 2020
This was referenced Mar 29, 2020
This was referenced Apr 6, 2020
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chinese, next/last prefix shows or not depends on the day and the base date are in the same week or not .