Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move argument length requirement checks to a shared function to dedupe code #1563

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Move argument length requirement checks to a shared function to dedupe code #1563

merged 1 commit into from
Jan 4, 2020

Commits on Jan 4, 2020

  1. Move argument length requirement checks to a shared function to dedup… 

    …e code.

I noticed in a compiled bundle that there were a lot of duplicated strings which were used for argument length validation, so I was interested to see what effect deduplicating these would have on bundle size.

Bundle | Bytes
-------|--------
Before | `25474`
Ater   | `24528`

That's a reduction of 946 bytes (3.71%) from a complete minified bundle.
    @levibuzolic
    levibuzolic committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    bc1a023 View commit details
    Browse the repository at this point in the history