Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop returning Date from differenceInBusinessDays #2012

Closed
kossnocorp opened this issue Oct 8, 2020 · 4 comments
Closed

Stop returning Date from differenceInBusinessDays #2012

kossnocorp opened this issue Oct 8, 2020 · 4 comments
Assignees
@kossnocorp
Labels
API 😈 Breaking
Milestone
v3.0

Comments

@kossnocorp
Copy link
Member

Right now differenceInBusinessDays returns Date if the arguments are invalid. This is not right and we need to fix it.
@kossnocorp kossnocorp added this to the v3 milestone Oct 8, 2020
@suraj-desai
Copy link

Hey @kossnocorp can you assign it to me? I can give a shot

@kossnocorp
Copy link
Member Author

@suraj-desai, this is a breaking change and won’t be shipped until v3, so better I would do it myself.

@kossnocorp kossnocorp self-assigned this Oct 8, 2020
@suraj-desai
Copy link

Okay. no problem.

@fturmel
Copy link
Member

fturmel commented Jan 30, 2022

This was actually fixed by #2414 when the function got converted to TypeScript, and released in v2.21.2

@fturmel fturmel closed this as completed Jan 30, 2022
@fturmel fturmel mentioned this issue Jan 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kossnocorp kossnocorp

Labels
API 😈 Breaking
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@kossnocorp @fturmel @suraj-desai