Add p+ token support to parse function #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kossnocorp and @marnusw Can you take a look and check if this makes sense? This should close #896, or at least make it more consistent. Also, it should fix Hacker0x01/react-datepicker#1774. |
kossnocorp
requested changes
Jun 7, 2019
|
This PR was released as |
4 tasks
elmomalmo
pushed a commit
to elmomalmo/date-fns
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no way to parse date strings using long localized date/time formats. This PR aims to add support to
p+tokens to theparsefunction.Added patterns:
and their combinations.
PS: Timezone time parses
pppandppppwere left out of this PR because thez+parsers are not yet implemented in the locales.