Skip to content

Commit

Permalink
Fix min & max argument types
Browse files Browse the repository at this point in the history
  • Loading branch information
kossnocorp committed Jul 23, 2021
1 parent a345b72 commit 4dec385
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions src/max/index.ts
Expand Up @@ -40,7 +40,7 @@ import requiredArgs from '../_lib/requiredArgs/index'
* ])
* //=> Sun Jul 02 1995 00:00:00
*/
export default function max(dirtyDatesArray: Date[] | string[] | number[]): Date {
export default function max(dirtyDatesArray: Array<Date | number>): Date {
requiredArgs(1, arguments)

let datesArray
Expand All @@ -57,10 +57,14 @@ export default function max(dirtyDatesArray: Date[] | string[] | number[]): Date
}

let result: Date | undefined
datesArray.forEach(function(dirtyDate) {
datesArray.forEach(function (dirtyDate) {
const currentDate = toDate(dirtyDate)

if (result === undefined || result < currentDate || isNaN(Number(currentDate))) {
if (
result === undefined ||
result < currentDate ||
isNaN(Number(currentDate))
) {
result = currentDate
}
})
Expand Down
2 changes: 1 addition & 1 deletion src/min/index.ts
Expand Up @@ -40,7 +40,7 @@ import requiredArgs from '../_lib/requiredArgs/index'
* ])
* //=> Wed Feb 11 1987 00:00:00
*/
export default function min(dirtyDatesArray: Date[] | number[]): Date {
export default function min(dirtyDatesArray: Array<Date | number>): Date {
requiredArgs(1, arguments)

let datesArray: Date[] | number[]
Expand Down

0 comments on commit 4dec385

Please sign in to comment.