Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add streaming namespace policy offload threshold #381

Merged
merged 1 commit into from
Mar 26, 2024
Merged

add streaming namespace policy offload threshold #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/resources/streaming_namespace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ Optional:
- `inactive_topic_policies` (Attributes) (see [below for nested schema](#nestedatt--policies--inactive_topic_policies))
- `is_allow_auto_update_schema` (Boolean)
- `message_ttl_in_seconds` (Number)
- `offload_threshold` (Number)
- `retention_policies` (Attributes) (see [below for nested schema](#nestedatt--policies--retention_policies))
- `schema_auto_update_compatibility_strategy` (String)
- `schema_compatibility_strategy` (String)
Expand Down
8 changes: 7 additions & 1 deletion internal/provider/types_streaming_namespace_policies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const (
policyInactiveTopicDeleteMode = "delete_mode"

policySubscriptionExpirationTimeMinutes = "subscription_expiration_time_minutes"
policyOffloadThreshold = "offload_threshold"
)

type PulsarNamespacePolicies struct {
Expand All @@ -65,6 +66,7 @@ type PulsarNamespacePolicies struct {
RetentionPolicies *PulsarNamespaceRetentionPolicies `tfsdk:"retention_policies" json:"retention_policies,omitempty"`
InactiveTopicPolicies *PulsarNamespaceInactiveTopicPolicies `tfsdk:"inactive_topic_policies" json:"inactive_topic_policies,omitempty"`
SubscriptionExpirationTimeMinutes *int64 `tfsdk:"subscription_expiration_time_minutes" json:"subscription_expiration_time_minutes,omitempty"`
OffloadThreshold *int64 `tfsdk:"offload_threshold" json:"offload_threshold,omitempty"`
}

type PulsarNamespaceRetentionPolicies struct {
Expand Down Expand Up @@ -199,6 +201,7 @@ var (
},
},
policySubscriptionExpirationTimeMinutes: int64PulsarNamespacePolicyAttribute,
policyOffloadThreshold: int64PulsarNamespacePolicyAttribute,
},
}
)
Expand Down Expand Up @@ -316,6 +319,10 @@ func setNamespacePolicies(ctx context.Context, client *pulsaradmin.ClientWithRes
resp, err := client.NamespacesSetSchemaValidationEnforced(ctx, tenant, namespace, *policies.SchemaValidationEnforced, requestEditors...)
diags.Append(HTTPResponseDiagWarn(resp, err, pulsarNamespacePolicyError(policySchemaValidationEnforced))...)
}
if policies.OffloadThreshold != nil {
resp, err := client.NamespacesSetOffloadThreshold(ctx, tenant, namespace, *policies.OffloadThreshold, requestEditors...)
diags.Append(HTTPResponseDiagWarn(resp, err, pulsarNamespacePolicyError(policyOffloadThreshold))...)
}

// Nested objects
if policies.AutoTopicCreationOverride != nil {
Expand All @@ -334,7 +341,6 @@ func setNamespacePolicies(ctx context.Context, client *pulsaradmin.ClientWithRes
resp, err := client.NamespacesSetRetention(ctx, tenant, namespace, *policies.RetentionPolicies, requestEditors...)
diags.Append(HTTPResponseDiagWarn(resp, err, pulsarNamespacePolicyError(policyRetentionPolicies))...)
}

if policies.InactiveTopicPolicies != nil {
resp, err := client.NamespacesSetInactiveTopicPolicies(ctx, tenant, namespace, *policies.InactiveTopicPolicies, requestEditors...)
diags.Append(HTTPResponseDiagWarn(resp, err, pulsarNamespacePolicyError(policyInactiveTopicPolicies))...)
Expand Down