ManagedCursor: chunk position info #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // this is not JSON | ||
| return ChunkSequenceFooter.NOT_CHUNKED; | ||
| } | ||
| return ObjectMapperFactory.getMapper().getObjectMapper().readValue(data, ChunkSequenceFooter.class); |
There was a problem hiding this comment.
isn't possible that first char is { for other reason?
maybe we should catch JSONProcessingException and assume it's not a ChunkSequenceFooter
There was a problem hiding this comment.
I don't think that it is possible with a ProtoBuf encoded message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implemetation to "Compression".
The idea is that we can persist the Position info, that can be huge, in multiple smaller BK entries.
The format is simple: in case of chunking we write all the entries and then a JSON footer.
During recover we read the footer and the previous N entries.
This patch is the initial part of the work, because we have to handle recovery of the case in which the broker crashes while writing the entries.
In this case we have to scan the ledger backward until we find a well-formed entry or a new "footer"